[PATCH 5.9 52/74] erofs: avoid duplicated permission check for "trusted." xattrs

[Greg Kroah-Hartman]

From: Gao Xiang <hsiang...@redhat.com>

commit d578b46db69d125a654f509bdc9091d84e924dc8 upstream.

Don't recheck it since xattr_permission() already
checks CAP_SYS_ADMIN capability.

Just follow 5d3ce4f70172 ("f2fs: avoid duplicated permission check for 
"trusted." xattrs")

Reported-by: Hongyu Jin <hongyu....@unisoc.com>
[ Gao Xiang: since it could cause some complex Android overlay
  permission issue as well on android-5.4+, it'd be better to
  backport to 5.4+ rather than pure cleanup on mainline. ]
Cc: <sta...@vger.kernel.org> # 5.4+
Link: https://lore.kernel.org/r/20200811070020.6339-1-hsiang...@redhat.com
Reviewed-by: Chao Yu <yuch...@huawei.com>
Signed-off-by: Gao Xiang <hsiang...@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

---
 fs/erofs/xattr.c |    2 --
 1 file changed, 2 deletions(-)

--- a/fs/erofs/xattr.c
+++ b/fs/erofs/xattr.c
@@ -473,8 +473,6 @@ static int erofs_xattr_generic_get(const
                        return -EOPNOTSUPP;
                break;
        case EROFS_XATTR_INDEX_TRUSTED:
-               if (!capable(CAP_SYS_ADMIN))
-                       return -EPERM;
                break;
        case EROFS_XATTR_INDEX_SECURITY:
                break;