Now we have for 'other' and 'type' variables

other   type    return
  0       0     REGION_DISJOINT
  0       x     REGION_INTERSECTS
  x       0     REGION_DISJOINT
  x       x     REGION_MIXED

Obviously it's easier to check 'type' for 0 first instead of
currently checked 'other'.

Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com>
---
 kernel/resource.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index 3ae2f56cc79d..82df80417489 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -557,13 +557,13 @@ int region_intersects(resource_size_t start, size_t size, 
unsigned long flags,
        }
        read_unlock(&resource_lock);
 
-       if (other == 0)
-               return type ? REGION_INTERSECTS : REGION_DISJOINT;
+       if (type == 0)
+               return REGION_DISJOINT;
 
-       if (type)
-               return REGION_MIXED;
+       if (other == 0)
+               return REGION_INTERSECTS;
 
-       return REGION_DISJOINT;
+       return REGION_MIXED;
 }
 EXPORT_SYMBOL_GPL(region_intersects);
 
-- 
2.28.0

Reply via email to