On Sat, Oct 31, 2020 at 10:26:30AM +0100, Miguel Ojeda wrote: > Hi Lars, > > On Thu, Oct 29, 2020 at 10:57 AM <[email protected]> wrote: > > > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > > index 81757eeded68..a56171d1a1ba 100644 > > --- a/drivers/auxdisplay/Kconfig > > +++ b/drivers/auxdisplay/Kconfig > > @@ -14,12 +14,31 @@ menuconfig AUXDISPLAY > > > > If you say N, all options in this submenu will be skipped and > > disabled. > > > > +config CHARLCD > > + tristate "Character LCD core support" if COMPILE_TEST > > + help > > + This is the base system for character-based LCD displays. > > + It makes no sense to have this alone, you select your display > > driver > > + and if it needs the charlcd core, it will select it automatically. > > + This is some character LCD core interface that multiple drivers > > can > > + use. > > + > > +config HD44780_COMMON > > + tristate "Common functions for HD44780 (and compatibles) LCD > > displays" if COMPILE_TEST > > + help > > + This is a module with the common symbols for HD44780 (and > > compatibles) > > + displays. This is the code that multiple other modules use. It is > > not > > + useful alone. If you have some sort of HD44780 compatible display, > > + you very likely use this. It is selected automatically by > > selecting > > + your concrete display. > > + > > if AUXDISPLAY > > > > These two should be after `if AUXDISPLAY`, no? I noticed the menu is > broken when I went to compile test this (the options appear outside > and the auxdisplay menu is empty). Perhaps you don't use menuconfig so > you didn't see it?
I did see it and had a look and did not spot anything obvious (to me). So I put this aside as "This is supposed to be this way." > Sorry I missed this in previous iterations... No need to be sorry. In the end it's my fault. I fix this. Regards, Lars
