Re: [PATCH 1/5] ARM: dts: exynos: Fix ethernet description for Odroid XU3

[Krzysztof Kozlowski]

On Tue, Nov 03, 2020 at 01:46:14PM +0100, Łukasz Stelmach wrote:
> Create ethernet alias 

Your commit msg should explain why.


> and assign appropriate compatible properties.

Then what was before? Indeed they do not look like anything
reasonable... old VID do not appear on any of Odroid boards.

> 
> Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com>
> ---

Best regards,
Krzysztof

>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts 
> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index d0f6ac5fa79d..2a4153484664 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -15,6 +15,10 @@
>  / {
>       model = "Hardkernel Odroid XU3";
>       compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", 
> "samsung,exynos5";
> +
> +     aliases {
> +             ethernet = &ethernet;
> +     };
>  };
>  
>  &i2c_0 {
> @@ -76,13 +80,13 @@ &usbhost2 {
>       #size-cells = <0>;
>  
>       hub@1 {
> -             compatible = "usb8087,0024";
> +             compatible = "usb0424,9514";
>               reg = <1>;
>               #address-cells = <1>;
>               #size-cells = <0>;
>  
>               ethernet: usbether@1 {
> -                     compatible = "usb0c45,6310";
> +                     compatible = "usb0424,ec00";
>                       reg = <1>;
>                       local-mac-address = [00 00 00 00 00 00]; /* Filled in 
> by a bootloader */
>               };
> -- 
> 2.26.2
>