On Tue, 4 Dec 2007 11:56:54 -0500 "Mike Frysinger" <[EMAIL PROTECTED]> wrote:
> On Dec 4, 2007 11:49 AM, Alessandro Zummo <[EMAIL PROTECTED]> wrote: > > On Tue, 4 Dec 2007 11:47:56 -0500 > > "Mike Frysinger" <[EMAIL PROTECTED]> wrote: > > > the return of ENOTTY is to say "changing of freq isnt supported", not > > > that the value is invalid. but i can get the same behavior by > > > deleting the function as the rtc-dev layer will take care of returning > > > ENOTTY. > > > > > > so the behavior is for the RTC_IRQP_SET ioctl: > > > - return ENOTTY if you cannot change freq > > > - the rtc-dev layer will do this for you if you do not set irq_set_freq > > > - return EINVAL if the requested freq is not within the capabilities > > > of the hardware > > > > > > sound about right ? > > > > yes, it is. I agree about deleting it. > > so, merge this patch and i'll follow up with another to delete the > func and update the documentation ? ok. You have my Signed-off-by: Alessandro Zummo <[EMAIL PROTECTED]> on the whole patch set. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
