On Wed, Nov 04, 2020 at 02:22:37PM +0100, Sylwester Nawrocki wrote: > On 04.11.2020 13:37, Krzysztof Kozlowski wrote: > > On Wed, Nov 04, 2020 at 11:36:52AM +0100, Sylwester Nawrocki wrote: > > >> diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile > >> index d203520..c2f9e9d 100644 > >> --- a/drivers/interconnect/Makefile > >> +++ b/drivers/interconnect/Makefile > >> @@ -6,3 +6,4 @@ icc-core-objs := core.o bulk.o > >> obj-$(CONFIG_INTERCONNECT) += icc-core.o > >> obj-$(CONFIG_INTERCONNECT_IMX) += imx/ > >> obj-$(CONFIG_INTERCONNECT_QCOM) += qcom/ > >> +obj-$(CONFIG_INTERCONNECT_SAMSUNG) += samsung/ > >> \ No newline at end of file > > > > This needs a fix. > > Corrected, thanks for pointing out. > > >> diff --git a/drivers/interconnect/samsung/Kconfig > >> b/drivers/interconnect/samsung/Kconfig > >> new file mode 100644 > >> index 0000000..508ed64 > >> --- /dev/null > >> +++ b/drivers/interconnect/samsung/Kconfig > >> @@ -0,0 +1,13 @@ > >> +# SPDX-License-Identifier: GPL-2.0-only > >> +config INTERCONNECT_SAMSUNG > >> + bool "Samsung interconnect drivers" > > > > "Samsung SoC interconnect drivers" > > Changed. > > >> + depends on ARCH_EXYNOS || COMPILE_TEST > > > > Don't the depend on INTERCONNECT? > > This file gets included only if INTERCONNECT is enabled, see > higher level Kconfig file.
I missed the include part, looks good. > > >> + help > >> + Interconnect drivers for Samsung SoCs. > >> + > >> + > > > > One line break > > Fixed. > > >> +config INTERCONNECT_EXYNOS > >> + tristate "Exynos generic interconnect driver" > >> + depends on INTERCONNECT_SAMSUNG > > > > How about: > > default y if ARCH_EXYNOS > > OK, added. > > >> + help > >> + Generic interconnect driver for Exynos SoCs. > >> diff --git a/drivers/interconnect/samsung/Makefile > >> b/drivers/interconnect/samsung/Makefile > >> new file mode 100644 > >> index 0000000..e19d1df > >> --- /dev/null > >> +++ b/drivers/interconnect/samsung/Makefile > >> @@ -0,0 +1,4 @@ > >> +# SPDX-License-Identifier: GPL-2.0 > >> +exynos-interconnect-objs := exynos.o > > > > What is this line for? > > That allows to change the module name, so it's exynos-interconnect.ko > rather than just exynos.c. It's done similarly for other SoCs in > the subsystem. Thanks, makes sense. Best regards, Krzysztof
