On 5/11/20 6:56 pm, Henrik Rydberg wrote: > Hi Brad, > > Great to see this effort, it is certainly an area which could be improved. > After having seen several generations of Macbooks while modifying much of > that code, it became clear that the SMC communication got refreshed a few > times over the years. Every tiny change had to be tested on all machines, or > kept separate for a particular generation, or something would break. > > I have not followed the back story here, but I imagine the need has arisen > because of a new refresh, and so this patch only needs to strictly apply to a > new generation. I would therefore advice that you write the patch in that > way, reducing the actual change to zero for earlier generations. It also > makes it easier to test the effect of the new approach on older systems. I > should be able to help testing on a 2008 and 2011 model once we get to that > stage.
G'day Henrik, Unfortunately I didn't make these changes to accommodate a "new generation". Changes made in kernel 5.9 broke it on my machine and in looking at why didn't identify any obvious causes, so I re-worked some of the comms. I can't guarantee it won't break older machines which is why I've asked for help testing it. I only have a MacbookPro 11,1 and an iMac 12,2. It fixes both of those. Help testing would be much appreciated. Regards, Brad
