On Thu, 5 Nov 2020 13:36:56 +0000 George Cherian wrote: > > Now i am a little bit skeptic here, devlink health reporter infrastructure > > was > > never meant to deal with dump op only, the main purpose is to > > diagnose/dump and recover. > > > > especially in your use case where you only report counters, i don't believe > > devlink health dump is a proper interface for this. > These are not counters. These are error interrupts raised by HW blocks. > The count is provided to understand on how frequently the errors are seen. > Error recovery for some of the blocks happen internally. That is the reason, > Currently only dump op is added.
The previous incarnation was printing messages to logs, so I assume these errors are expected to be relatively low rate. The point of using devlink health was that you can generate a netlink notification when the error happens. IOW you need some calls to devlink_health_report() or such. At least that's my thinking, others may disagree.
