From: Hou Tao <hout...@huawei.com>

Exclusive locks do not have readlock support, which means that a
locktorture run with the following module parameters will do nothing:

 torture_type=mutex_lock nwriters_stress=0 nreaders_stress=1

This commit therefore rejects this combination for exclusive locks by
returning -EINVAL during module init.

Signed-off-by: Hou Tao <hout...@huawei.com>
Signed-off-by: Paul E. McKenney <paul...@kernel.org>
---
 kernel/locking/locktorture.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
index 316531d..046ea2d 100644
--- a/kernel/locking/locktorture.c
+++ b/kernel/locking/locktorture.c
@@ -870,7 +870,8 @@ static int __init lock_torture_init(void)
                goto unwind;
        }
 
-       if (nwriters_stress == 0 && nreaders_stress == 0) {
+       if (nwriters_stress == 0 &&
+           (!cxt.cur_ops->readlock || nreaders_stress == 0)) {
                pr_alert("lock-torture: must run at least one locking 
thread\n");
                firsterr = -EINVAL;
                goto unwind;
-- 
2.9.5

Reply via email to