>> Assign initial values to local variables that may be returned >> >> Signed-off-by: Wang Qing <wangq...@vivo.com> > >Your subject, and body of text, seem to have 2 "odd" characters in it, >please fix up. > >Also, your subject and changelog body here are identical, please be much >more verbose in the body explaining why you are doing something, not >just what you are doing. > >And your subject line should also match other patches for this file, and >have "usb: phy: ..." in the beginning. Yeah, I got it. > >> --- >> drivers/usb/phy/phy.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c >> index b47285f..de21967 >> --- a/drivers/usb/phy/phy.c >> +++ b/drivers/usb/phy/phy.c >> @@ -59,7 +59,7 @@ static struct usb_phy *__usb_find_phy(struct list_head >> *list, >> >> static struct usb_phy *__of_usb_find_phy(struct device_node *node) >> { >> - struct usb_phy *phy; >> + struct usb_phy *phy = NULL; > >Why isn't the compiler complaining about this today? Are you sure this >is needed? Sorry, I didn't look at it carefully, because __usb_find_phy has an initial value, and I was affected.. You don't need to modify it, In fact.
thanks, Wang Qing > >thanks, > >greg k-h