Hi Greg, On Fri, Nov 06, 2020 at 10:33:02AM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 06, 2020 at 12:59:07AM -0800, Prashant Malani wrote: > > Hi Greg, > > > > Did you not receive these? > > Ah, I got 1, 2, and 5, and now 6. That's confusing, think about if you > were to receive such a series, what would you think to do with it? >
Yeah, I agree it looks confusing. Sorry about that. > > > So you save it but what happens with the value? > > > > The type C connector class framework exposes it via syfs to user-space when > > we > > register the cable via typec_register_cable() in patch 4/6 [2]. > > So you added a new sysfs file and api without updating > Documentation/ABI/? That's not good :( This is a pre-existing API[1] and sysfs file[2] so we are using those and not adding anything new. [1]: https://www.kernel.org/doc/html/latest/driver-api/usb/typec.html#c.typec_register_cable [2]: https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-class-typec (see /sys/class/<port>-cable/plug_type) Best regards,
