On Fri, Nov 06, 2020 at 07:33:33PM +0800, Alex Shi wrote:
> The page->mem_cgroup member is replaced by memcg_data, and add a helper
> page_memcg() for it. Need to update comments to avoid confusing.
I'm not an expert in this code but IMO the pointer manipulation of
page->mem_cgroup could be thought of as local to the code in mm/memcontrol.c.
As such the detail of the member of the page struct that the code depends on is
a valuable part of the comment. Having to look at page_memcg() to find out
this information is kind of annoying.
Ira
>
> Signed-off-by: Alex Shi <alex....@linux.alibaba.com>
> Cc: Johannes Weiner <han...@cmpxchg.org>
> Cc: Michal Hocko <mho...@kernel.org>
> Cc: Vladimir Davydov <vdavydov....@gmail.com>
> Cc: Andrew Morton <a...@linux-foundation.org>
> Cc: cgro...@vger.kernel.org
> Cc: linux...@kvack.org
> Cc: linux-kernel@vger.kernel.org
> ---
> mm/memcontrol.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index b2aa3b73ab82..8a8debea34fc 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -1310,7 +1310,7 @@ int mem_cgroup_scan_tasks(struct mem_cgroup *memcg,
> * @page: the page
> * @pgdat: pgdat of the page
> *
> - * This function relies on page->mem_cgroup being stable - see the
> + * This function relies on page_memcg(page) being stable - see the
> * access rules in commit_charge().
> */
> struct lruvec *mem_cgroup_page_lruvec(struct page *page, struct pglist_data
> *pgdat)
> @@ -2862,7 +2862,7 @@ static void commit_charge(struct page *page, struct
> mem_cgroup *memcg)
> {
> VM_BUG_ON_PAGE(page_memcg(page), page);
> /*
> - * Any of the following ensures page->mem_cgroup stability:
> + * Any of the following ensures page_memcg(page) stability:
> *
> * - the page lock
> * - LRU isolation
> --
> 1.8.3.1
>
