On Sat, Nov 07, 2020 at 01:51:51PM +0530, Vaibhav Gupta wrote: > After the commit c5eb1190074c ("PCI / PM: Allow runtime PM without callback > functions") we no more need empty stubs for runtime-pm to work. > > The driver has no device specific task(s) for .suspend() . The stub was > placed just for runtime-pm, which can be dropped now. > > Reported-by: Bjorn Helgaas <bhelg...@google.com> > Signed-off-by: Vaibhav Gupta <vaibhavgupt...@gmail.com> > --- > drivers/i2c/busses/i2c-nvidia-gpu.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c > b/drivers/i2c/busses/i2c-nvidia-gpu.c > index f9a69b109e5c..6b20601ffb13 100644 > --- a/drivers/i2c/busses/i2c-nvidia-gpu.c > +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c > @@ -353,15 +353,7 @@ static void gpu_i2c_remove(struct pci_dev *pdev) > pci_free_irq_vectors(pdev); > } > > -/* > - * We need gpu_i2c_suspend() even if it is stub, for runtime pm to work > - * correctly. Without it, lspci shows runtime pm status as "D0" for the card. > - * Documentation/power/pci.rst also insists for driver to provide this. > - */ > -static __maybe_unused int gpu_i2c_suspend(struct device *dev) > -{ > - return 0; > -} > +#define gpu_i2c_suspend NULL > > static __maybe_unused int gpu_i2c_resume(struct device *dev) > { > -- > 2.28.0 > The patch is only compile-tested.
--Vaibhav