On Sat, Nov 07, 2020 at 12:11:32AM -0800, Nick Desaulniers wrote: > Clang is more aggressive about -Wformat warnings when the format flag > specifies a type smaller than the parameter. Turns out, struct > Scsi_Host's member can_queue is actually an int. Fixes: > > warning: format specifies type 'short' but the argument has type 'int' > [-Wformat] > shost_rd_attr(can_queue, "%hd\n"); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > %d > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Signed-off-by: Nick Desaulniers <ndesaulni...@google.com>
Reviewed-by: Nathan Chancellor <natechancel...@gmail.com> > --- > drivers/scsi/scsi_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c > index d6e344fa33ad..b6378c8ca783 100644 > --- a/drivers/scsi/scsi_sysfs.c > +++ b/drivers/scsi/scsi_sysfs.c > @@ -370,7 +370,7 @@ static DEVICE_ATTR(eh_deadline, S_IRUGO | S_IWUSR, > show_shost_eh_deadline, store > > shost_rd_attr(unique_id, "%u\n"); > shost_rd_attr(cmd_per_lun, "%hd\n"); > -shost_rd_attr(can_queue, "%hd\n"); > +shost_rd_attr(can_queue, "%d\n"); > shost_rd_attr(sg_tablesize, "%hu\n"); > shost_rd_attr(sg_prot_tablesize, "%hu\n"); > shost_rd_attr(unchecked_isa_dma, "%d\n"); > -- > 2.29.2.222.g5d2a92d10f8-goog >
