On 9/11/20 1:27 am, Joe Perches wrote:
> On Sun, 2020-11-08 at 19:13 +0530, Aditya Srivastava wrote:
>> Currently, checkpatch warns us if the author of the commit signs-off
>> as co-developed-by.
> []
>> A quick manual check found out that all fixes were correct in those
>> cases.
> []
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> @@ -2827,8 +2827,11 @@ sub process {
>> # Check Co-developed-by: immediately followed by Signed-off-by: with same
>> name and email
>> if ($sign_off =~ /^co-developed-by:$/i) {
>> if ($email eq $author) {
>> - WARN("BAD_SIGN_OFF",
>> - "Co-developed-by: should not be
>> used to attribute nominal patch author '$author'\n" . "$here\n" . $rawline);
>> + if (WARN("BAD_SIGN_OFF",
>> + "Co-developed-by: should not
>> be used to attribute nominal patch author '$author'\n" . "$here\n" .
>> $rawline) &&
>> + $fix) {
>> + fix_delete_line($fixlinenr,
>> $rawline);
>> + }
>> }
>> if (!defined $lines[$linenr]) {
>> WARN("BAD_SIGN_OFF",
>
> Looks OK to me.
>
> Another option might be to add a Signed-off-by: line derived from
> any "From:" line when:
>
> if ($is_patch && $has_commit_log && $chk_signoff) {
> if ($signoff == 0) {
> ERROR("MISSING_SIGN_OFF",
> "Missing Signed-off-by: line(s)\n");
>
> etc...
>
Yes, I just noticed. Thanks for the suggestion. Will do.
Thanks
Aditya
