On Mon, Nov 09, 2020 at 05:08:36PM +0530, Anshuman Khandual wrote: > Mapping between IPI type index and its string is direct without requiring > an additional offset. Hence the existing macro S(x, s) is now redundant > and can just be dropped. This also makes the code clean and simple. > > Cc: Catalin Marinas <[email protected]> > Cc: Will Deacon <[email protected]> > Cc: Mark Rutland <[email protected]> > Cc: Marc Zyngier <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Anshuman Khandual <[email protected]>
Nice cleanup! Acked-by: Mark Rutland <[email protected]> Mark. > --- > arch/arm64/kernel/smp.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > index 09c96f57818c..65d18a618abe 100644 > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -786,14 +786,13 @@ void __init smp_prepare_cpus(unsigned int max_cpus) > } > > static const char *ipi_types[NR_IPI] __tracepoint_string = { > -#define S(x,s) [x] = s > - S(IPI_RESCHEDULE, "Rescheduling interrupts"), > - S(IPI_CALL_FUNC, "Function call interrupts"), > - S(IPI_CPU_STOP, "CPU stop interrupts"), > - S(IPI_CPU_CRASH_STOP, "CPU stop (for crash dump) interrupts"), > - S(IPI_TIMER, "Timer broadcast interrupts"), > - S(IPI_IRQ_WORK, "IRQ work interrupts"), > - S(IPI_WAKEUP, "CPU wake-up interrupts"), > + [IPI_RESCHEDULE] = "Rescheduling interrupts", > + [IPI_CALL_FUNC] = "Function call interrupts", > + [IPI_CPU_STOP] = "CPU stop interrupts", > + [IPI_CPU_CRASH_STOP] = "CPU stop (for crash dump) interrupts", > + [IPI_TIMER] = "Timer broadcast interrupts", > + [IPI_IRQ_WORK] = "IRQ work interrupts", > + [IPI_WAKEUP] = "CPU wake-up interrupts", > }; > > static void smp_cross_call(const struct cpumask *target, unsigned int ipinr); > -- > 2.20.1 >
