On Tue, 10 Nov 2020, [email protected] wrote: > From: Michael Srba <[email protected]> > > Fix regulators on rt5033 by converting some values to bitmasks which were > errorneously not defined as such in the header file. > > Cc: Beomho Seo <[email protected]> > Fixes: 0b271258544b ("mfd: rt5033: Add Richtek RT5033 driver core.") > Signed-off-by: Michael Srba <[email protected]> > --- > > Tested on Samsung Galaxy A3 (sm-a3ulte). > > Other areas (e.g "RT5033 use internal timer need to set time") still look > suspicious, but without access to a datasheet it's unfortunately hard > to evaluate. Moreover, these values are not currently utilized so it's not > clear what format would be expected. (it's however hard to argue for > the removal of said values, since with the datasheet not being publicly > available, this file may be the best documentation of them) > > --- > include/linux/mfd/rt5033-private.h | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-)
Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
