Hi Wang,
Wang Hai <wangha...@huawei.com> writes:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 4c2703dfd7fa ("net: marvell: prestera: Add PCI interface support")
> Reported-by: Hulk Robot <hul...@huawei.com>
> Signed-off-by: Wang Hai <wangha...@huawei.com>
> ---
> drivers/net/ethernet/marvell/prestera/prestera_pci.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> b/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> index 1b97adae542e..be5677623455 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> @@ -676,7 +676,8 @@ static int prestera_pci_probe(struct pci_dev *pdev,
> if (err)
> return err;
>
> - if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(30))) {
> + err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(30));
> + if (err) {
> dev_err(&pdev->dev, "fail to set DMA mask\n");
> goto err_dma_mask;
> }
> @@ -702,8 +703,10 @@ static int prestera_pci_probe(struct pci_dev *pdev,
> dev_info(fw->dev.dev, "Prestera FW is ready\n");
>
> fw->wq = alloc_workqueue("prestera_fw_wq", WQ_HIGHPRI, 1);
> - if (!fw->wq)
> + if (!fw->wq) {
> + err = -ENOMEM;
> goto err_wq_alloc;
> + }
>
> INIT_WORK(&fw->evt_work, prestera_fw_evt_work_fn);
Thank you!
Just in case it is needed:
Reviewed-by: Vadym Kochan <vadym.koc...@plvision.eu>
Acked-by: Vadym Kochan <vadym.koc...@plvision.eu>
