Re: [PATCH 3/3 v6] livepatch: Use the default ftrace_ops instead of REGS when ARGS is available

[Steven Rostedt]

On Fri, 13 Nov 2020 12:31:11 +0100 (CET)
Miroslav Benes <mbe...@suse.cz> wrote:

> > +++ b/arch/x86/include/asm/livepatch.h
> > @@ -12,9 +12,9 @@
> >  #include <asm/setup.h>
> >  #include <linux/ftrace.h>
> >  
> > -static inline void klp_arch_set_pc(struct pt_regs *regs, unsigned long ip)
> > +static inline void klp_arch_set_pc(struct ftrace_regs *fregs, unsigned 
> > long ip)
> >  {
> > -   regs->ip = ip;
> > +   ftrace_regs_set_ip(fregs, ip);  
> 
> You forgot to update the call site :)

Bah. This would have been caught via my full test suite, but I only ran
the cross compiling tests :-P

Thanks, will fix in v7.

-- Steve