On Mon, Nov 09, 2020 at 12:47:23PM -0800, Bhaumik Bhatt wrote: > In some cases, the entry of device to RDDM execution environment > can occur after a significant amount of time has elapsed and a > SYS_ERROR state change event has already arrived. This can result > in scenarios where MHI controller and client drivers are unaware > of the error state of the device. Remove the check for rddm_image > when processing the SYS_ERROR state change as it is present in > mhi_pm_sys_err_handler() already and prevent further activity > until the expected RDDM execution environment change occurs or > the controller driver decides further action. > > Signed-off-by: Bhaumik Bhatt <[email protected]>
Reviewed-by: Manivannan Sadhasivam <[email protected]> Thanks, Mani > --- > drivers/bus/mhi/core/main.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > index f953e2a..91f8b8d 100644 > --- a/drivers/bus/mhi/core/main.c > +++ b/drivers/bus/mhi/core/main.c > @@ -737,11 +737,6 @@ int mhi_process_ctrl_ev_ring(struct mhi_controller > *mhi_cntrl, > { > enum mhi_pm_state new_state; > > - /* skip SYS_ERROR handling if RDDM supported */ > - if (mhi_cntrl->ee == MHI_EE_RDDM || > - mhi_cntrl->rddm_image) > - break; > - > dev_dbg(dev, "System error detected\n"); > write_lock_irq(&mhi_cntrl->pm_lock); > new_state = mhi_tryset_pm_state(mhi_cntrl, > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
