Ben Hutchings, le lun. 16 nov. 2020 19:51:23 +0000, a ecrit: > On Mon, 2020-11-16 at 20:01 +0100, Samuel Thibault wrote: > > Perhaps we should rather use > > > > depends on ISA || (X86 && COMPILE_TEST) > > > > ? > > so that we have compile testing on x86 only (where the inb/outb macros > > always behave fine) to avoid such issues on other archs? > > That seems reasonable though unusual. > > > Or we tell the architecture maintainers to fix their out macros into > > consuming their parameters? > [...] > > It does seem odd for parisc to define the I/O functions this way. I > don't know if it's really a bug.
Sorry I wasn't clear: the problem here is when CONFIG_EISA is disabled, the eisa_in/out calls are replaced by BUG() stubs, and the stubs do not consume their input: arch/parisc/include/asm/io.h #if defined(CONFIG_PCI) extern void outb(unsigned char b, int addr); #elif defined(CONFIG_EISA) #define outb eisa_out8 #else #define outb(x, y) BUG() #endif Samuel
