> -----Original Message-----
> From: Oscar Salvador [mailto:osalva...@suse.de]
> Sent: Wednesday, November 18, 2020 8:45 AM
> To: Muchun Song <songmuc...@bytedance.com>
> Cc: Song Bao Hua (Barry Song) <song.bao....@hisilicon.com>;
> cor...@lwn.net; mike.krav...@oracle.com; t...@linutronix.de;
> mi...@redhat.com; b...@alien8.de; x...@kernel.org; h...@zytor.com;
> dave.han...@linux.intel.com; l...@kernel.org; pet...@infradead.org;
> v...@zeniv.linux.org.uk; a...@linux-foundation.org; paul...@kernel.org;
> mchehab+hua...@kernel.org; pawan.kumar.gu...@linux.intel.com;
> rdun...@infradead.org; oneu...@suse.com; anshuman.khand...@arm.com;
> jroe...@suse.de; almasrym...@google.com; rient...@google.com;
> wi...@infradead.org; mho...@suse.com; duanxiongc...@bytedance.com;
> linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; linux...@kvack.org;
> linux-fsde...@vger.kernel.org
> Subject: Re: [External] RE: [PATCH v4 00/21] Free some vmemmap pages of
> hugetlb page
> 
> On 2020-11-17 17:29, Muchun Song wrote:
> > Now for the 2MB HugrTLB page, we only free 6 vmemmap pages.
> > But your words woke me up. Maybe we really can free 7 vmemmap
> > pages. In this case, we can see 8 of the 512 struct page structures
> > has beed set PG_head flag. If we can adjust compound_head()
> > slightly and make compound_head() return the real head struct
> > page when the parameter is the tail struct page but with PG_head
> > flag set. I will start an investigation and a test.
> 
> I would not overcomplicate things at this stage, but rather keep it
> simple as the code is already tricky enough(without counting the LOC
> thatvit adds).
> We can always build on top later on in order to improve things.

Yep. I am not expecting freeing tail page to be done at this stage. This could
be something in the todo list after the first patchset is solid.

> 
> --
> Oscar Salvador
> SUSE L3

Thanks
Barry

Reply via email to