On Wed, 2020-11-18 at 10:41 +0800, Yingjoe Chen wrote: > On Mon, 2020-11-09 at 10:03 +0800, Weiyi Lu wrote: > > Add MT8192 imp i2c wrapper clock provider > > > > Signed-off-by: Weiyi Lu <weiyi...@mediatek.com> > > --- > > drivers/clk/mediatek/Kconfig | 6 ++ > > drivers/clk/mediatek/Makefile | 1 + > > drivers/clk/mediatek/clk-mt8192-imp_iic_wrap.c | 119 > > +++++++++++++++++++++++++ > > 3 files changed, 126 insertions(+) > > create mode 100644 drivers/clk/mediatek/clk-mt8192-imp_iic_wrap.c > > > > diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig > > index eb549f8..8acc7d6 100644 > > --- a/drivers/clk/mediatek/Kconfig > > +++ b/drivers/clk/mediatek/Kconfig > > @@ -515,6 +515,12 @@ config COMMON_CLK_MT8192_IMGSYS > > help > > This driver supports MediaTek MT8192 imgsys and imgsys2 clocks. > > > > +config COMMON_CLK_MT8192_IMP_IIC_WRAP > > + bool "Clock driver for MediaTek MT8192 imp_iic_wrap" > > + depends on COMMON_CLK_MT8192 > > + help > > + This driver supports MediaTek MT8192 imp_iic_wrap clocks. > > + > > config COMMON_CLK_MT8516 > > bool "Clock driver for MediaTek MT8516" > > depends on ARCH_MEDIATEK || COMPILE_TEST > > <...> > > > + > > +static struct platform_driver clk_mt8192_imp_iic_wrap_drv = { > > + .probe = mtk_clk_simple_probe, > > Good to have this generic probe function. Now several mtk clk drivers > are just a few data. > > But this series still add >10 configs for mt8192 clock drivers. Why do > we need separate configs for clocks of different domain? I don't think > they need lots of resource. We should review the rationale and reduce > the numbers. > Hi Joe,
Thanks for reviewing. There have been some discussions in patch[1] as to why the subsystem clocks are now separated by different configs. And we do need these clocks to be optional on some MediatTek SoC platform. I thought it it now a rationale number of subsystem clock provider drivers. In this series, we have reduced from 23 to 12. [1] https://patchwork.kernel.org/project/linux-mediatek/patch/1460621514-65191-5-git-send-email-jamesjj.l...@mediatek.com/ > > Joe.C > >