Hi Andy!

> On Thu, Nov 19, 2020 at 11:12:33AM +0100, Flavio Suligoi wrote:
> 
> Thank you very much for nice piece of documentation!
> My comments below.

Thanks for your suggestions! I'll use them in the next version
of the patch!

> > +particular the DSDT (see also [2])::
> 
> > +   cd /sys/firmware/acpi
> > +   cp -a tables/ ~
> > +   cd ~/tables/
> 
> acpidump followed by acpixtract from ACPI tools is better to advertise.

Ok, I'll use acpixtract

> 
> > +   find . -type f -exec mv {} {}.aml \;
> 
> Unnecessary step. But I think you wanted to have it to distinguish sources
> and
> binaries in the text below.

Right, I think that is important include the SSDT tables for external
symbol resolution. For this reason I renamed the binary tables, to
use the following command:

> > +   iasl -e SSDT?.* -d DSDT.aml

> --
> With Best Regards,
> Andy Shevchenko
> 

Best regards,
Flavio

Reply via email to