> On Nov 20, 2020, at 1:26 PM, Gustavo A. R. Silva <gustavo...@kernel.org> > wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding a couple of break statements instead of > just letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavo...@kernel.org> > --- > fs/nfsd/nfs4state.c | 1 + > fs/nfsd/nfsctl.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index d7f27ed6b794..cdab0d5be186 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -3113,6 +3113,7 @@ nfsd4_exchange_id(struct svc_rqst *rqstp, struct > nfsd4_compound_state *cstate, > goto out_nolock; > } > new->cl_mach_cred = true; > + break; > case SP4_NONE: > break; > default: /* checked by xdr code */ > diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c > index f6d5d783f4a4..9a3bb1e217f9 100644 > --- a/fs/nfsd/nfsctl.c > +++ b/fs/nfsd/nfsctl.c > @@ -1165,6 +1165,7 @@ static struct inode *nfsd_get_inode(struct super_block > *sb, umode_t mode) > inode->i_fop = &simple_dir_operations; > inode->i_op = &simple_dir_inode_operations; > inc_nlink(inode); > + break; > default: > break; > } > -- > 2.27.0 > Acked-by: Chuck Lever <chuck.le...@oracle.com> -- Chuck Lever
- [PATCH 014/141] media: usb: dvb-usb-v2: Fix fall-throu... Gustavo A. R. Silva
- [PATCH 045/141] net: mscc: ocelot: Fix fall-through wa... Gustavo A. R. Silva
- [PATCH 048/141] perf/x86: Fix fall-through warnings fo... Gustavo A. R. Silva
- [PATCH 047/141] nfp: Fix fall-through warnings for Cla... Gustavo A. R. Silva
- [PATCH 049/141] pinctrl: Fix fall-through warnings for... Gustavo A. R. Silva
- Re: [PATCH 049/141] pinctrl: Fix fall-through war... Geert Uytterhoeven
- [PATCH 015/141] netfilter: Fix fall-through warnings f... Gustavo A. R. Silva
- Re: [PATCH 015/141] netfilter: Fix fall-through w... Florian Westphal
- [PATCH 050/141] RDMA/mlx5: Fix fall-through warnings f... Gustavo A. R. Silva
- [PATCH 016/141] nfsd: Fix fall-through warnings for Cl... Gustavo A. R. Silva
- Re: [PATCH 016/141] nfsd: Fix fall-through warnin... Chuck Lever
- [PATCH 043/141] net: cassini: Fix fall-through warning... Gustavo A. R. Silva
- [PATCH 046/141] netxen_nic: Fix fall-through warnings ... Gustavo A. R. Silva
- [PATCH 051/141] reiserfs: Fix fall-through warnings fo... Gustavo A. R. Silva
- [PATCH 053/141] selinux: Fix fall-through warnings for... Gustavo A. R. Silva
- [PATCH 052/141] security: keys: Fix fall-through warni... Gustavo A. R. Silva
- [PATCH 055/141] uprobes/x86: Fix fall-through warnings... Gustavo A. R. Silva
- [PATCH 054/141] target: Fix fall-through warnings for ... Gustavo A. R. Silva
- [PATCH 057/141] watchdog: Fix fall-through warnings fo... Gustavo A. R. Silva
- Re: [PATCH 057/141] watchdog: Fix fall-through wa... Guenter Roeck
- [PATCH 056/141] vxge: Fix fall-through warnings for Cl... Gustavo A. R. Silva