From: Xiongfeng Wang <wangxiongfe...@huawei.com>

[ Upstream commit 6654b57866b98230a270953dd34f67de17ab1708 ]

Fix to return a negative error code from the error handling case instead
of 0 in function sun8i_dw_hdmi_bind().

Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver")
Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Xiongfeng Wang <wangxiongfe...@huawei.com>
Reviewed-by: Jernej Skrabec <jernej.skra...@siol.net>
Signed-off-by: Jernej Skrabec <jernej.skra...@siol.net>
Link: 
https://patchwork.freedesktop.org/patch/msgid/1605488969-5211-1-git-send-email-wangxiongfe...@huawei.com
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c 
b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
index a44dca4b0219e..12fe241956213 100644
--- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
+++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
@@ -209,6 +209,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct 
device *master,
        phy_node = of_parse_phandle(dev->of_node, "phys", 0);
        if (!phy_node) {
                dev_err(dev, "Can't found PHY phandle\n");
+               ret = -EINVAL;
                goto err_disable_clk_tmds;
        }
 
-- 
2.27.0



Reply via email to