Hi Jarod, Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master] [also build test ERROR on next-20201123] [cannot apply to net/master linux/master linus/master sparc-next/master v5.10-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jarod-Wilson/bonding-fix-feature-flag-setting-at-init-time/20201123-111956 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git f9e425e99b0756c1479042afe761073779df2a30 config: x86_64-rhel (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/6d883c4c2b01573ba9dddcb9fe109f961a8b7f10 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jarod-Wilson/bonding-fix-feature-flag-setting-at-init-time/20201123-111956 git checkout 6d883c4c2b01573ba9dddcb9fe109f961a8b7f10 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/net/bonding/bond_options.c: In function 'bond_option_mode_set': >> drivers/net/bonding/bond_options.c:752:38: error: 'BOND_XFRM_FEATURES' >> undeclared (first use in this function) 752 | netdev_features_t mask = features & BOND_XFRM_FEATURES; | ^~~~~~~~~~~~~~~~~~ drivers/net/bonding/bond_options.c:752:38: note: each undeclared identifier is reported only once for each function it appears in drivers/net/bonding/bond_options.c:752:20: warning: unused variable 'mask' [-Wunused-variable] 752 | netdev_features_t mask = features & BOND_XFRM_FEATURES; | ^~~~ vim +/BOND_XFRM_FEATURES +752 drivers/net/bonding/bond_options.c 747 748 static int bond_option_mode_set(struct bonding *bond, 749 const struct bond_opt_value *newval) 750 { 751 netdev_features_t features = bond->dev->features; > 752 netdev_features_t mask = features & BOND_XFRM_FEATURES; 753 754 if (!bond_mode_uses_arp(newval->value)) { 755 if (bond->params.arp_interval) { 756 netdev_dbg(bond->dev, "%s mode is incompatible with arp monitoring, start mii monitoring\n", 757 newval->string); 758 /* disable arp monitoring */ 759 bond->params.arp_interval = 0; 760 } 761 762 if (!bond->params.miimon) { 763 /* set miimon to default value */ 764 bond->params.miimon = BOND_DEFAULT_MIIMON; 765 netdev_dbg(bond->dev, "Setting MII monitoring interval to %d\n", 766 bond->params.miimon); 767 } 768 } 769 770 if (newval->value == BOND_MODE_ALB) 771 bond->params.tlb_dynamic_lb = 1; 772 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
