On Tue, 11 Dec 2007 08:13:52 -0800 "Martin Bligh" <[EMAIL PROTECTED]> wrote:
> > > > > > - Lots of device IDs have been removed from the e1000 driver and moved > > over > > to e1000e. So if your e1000 stops working, you forgot to set > > CONFIG_E1000E. > > > > > Wouldn't it make sense to just default this to on if E1000 was on, rather > than screwing > everybody for no good reason (plus breaking all the automated testing, etc > etc)? > Much though I love random refactoring, it is fairly painful to just keep > changing the > names of things. (cc netdev and Auke) Yes, that would be very sensible. CONFIG_E1000E should default to whatever CONFIG_E1000 was set to. > > I can't see this compile failure posted anywhere: > http://test.kernel.org/results/IBM/126049/build/debug/stderr > > arch/x86/vdso/vdso32/sigreturn.S: Assembler messages: > arch/x86/vdso/vdso32/sigreturn.S:23: Error: suffix or operands invalid for > `pop' > arch/x86/vdso/vdso32/syscall.S:25: Error: suffix or operands invalid for `pop' > make[1]: *** [arch/x86/vdso/vdso32/syscall.o] Error 1 > make: *** [arch/x86/vdso] Error 2 (cc Ingo and Thomas) > > Nor this one: > http://test.kernel.org/results/IBM/126096/build/debug/stderr > > drivers/char/hvcs.c: In function ‘hvcs_open’: > drivers/char/hvcs.c:1180: error: wrong type argument to unary exclamation mark > (cc Greg) Caused by gregkh-driver-kobject-convert-hvcs-to-use-kref-not-kobject.patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
