Hi Daniel,
Le mer. 25 nov. 2020 à 11:23, Daniel Lezcano
<[email protected]> a écrit :
The function ingenic_tcu_get_clock() is annotated for the __init
section but it is actually called from the online cpu callback.
That will lead to a crash if a CPU is hotplugged after boot time.
Remove the __init annotatation for the ingenic_tcu_get_clock()
function.
One 'ta' too many ;)
Fixes: f19d838d08fc (clocksource/drivers/ingenic: Add high resolution
timer support for SMP/SMT)
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Daniel Lezcano <[email protected]>
With the above fixed:
Reviewed-by: Paul Cercueil <[email protected]>
Cheers,
-Paul
---
drivers/clocksource/ingenic-timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/ingenic-timer.c
b/drivers/clocksource/ingenic-timer.c
index 58fd9189fab7..905fd6b163a8 100644
--- a/drivers/clocksource/ingenic-timer.c
+++ b/drivers/clocksource/ingenic-timer.c
@@ -127,7 +127,7 @@ static irqreturn_t ingenic_tcu_cevt_cb(int irq,
void *dev_id)
return IRQ_HANDLED;
}
-static struct clk * __init ingenic_tcu_get_clock(struct device_node
*np, int id)
+static struct clk *ingenic_tcu_get_clock(struct device_node *np, int
id)
{
struct of_phandle_args args;
--
2.25.1
