On Thu, Nov 26, 2020 at 02:15:35AM +0000, Alice Guo wrote: > > > > -----Original Message----- > > From: linux-arm-kernel <linux-arm-kernel-boun...@lists.infradead.org> On > > Behalf Of Adam Ford > > Sent: 2020年11月25日 8:45 > > To: Alice Guo <alice....@nxp.com> > > Cc: devicetree <devicet...@vger.kernel.org>; Peng Fan <peng....@nxp.com>; > > Sascha Hauer <s.ha...@pengutronix.de>; Linux Kernel Mailing List > > <linux-kernel@vger.kernel.org>; Krzysztof Kozlowski <k...@kernel.org>; Rob > > Herring <robh...@kernel.org>; dl-linux-imx <linux-...@nxp.com>; Shawn Guo > > <shawn...@kernel.org>; arm-soc <linux-arm-ker...@lists.infradead.org> > > Subject: Re: [PATCH v6 4/4] soc: imx8m: change to use platform driver > > > > On Mon, Nov 23, 2020 at 8:04 PM Alice Guo <alice....@nxp.com> wrote: > > > > > > Directly reading ocotp register depends on that bootloader enables > > > ocotp clk, which is not always effective, so change to use nvmem API. > > > Using nvmem API requires to support driver defer probe and thus change > > > soc-imx8m.c to use platform driver. > > > > > > The other reason is that directly reading ocotp register causes kexec > > > kernel hang because the 1st kernel running will disable unused clks > > > after kernel boots up, and then ocotp clk will be disabled even if > > > bootloader enables it. When kexec kernel, ocotp clk needs to be > > > enabled before reading ocotp registers, and nvmem API with platform > > > driver supported can accomplish this. > > > > > > Signed-off-by: Alice Guo <alice....@nxp.com> > > > --- > > > > > The patch reads V6, but the change log only shows V2. Can you elaborate on > > what has changed between V2 and V6? > > > > adam > > Hi, > > Sorry. The order of changlog is reversed. Thank Adam for pointing out the > problem, and thank Krzysztof for reviewing my patch. > Do I need to resend the patchset with the correct changelog order?
No, no need. Best regards, Krzysztof
