Re: [PATCH v3 1/5] genirq/affinity: Add irq_update_affinity_desc()

[Daniel Wagner]

Hi John,

On Thu, Nov 26, 2020 at 01:20:37AM +0800, John Garry wrote:
> +     activated = irqd_is_activated(&desc->irq_data);
> +     if (activated)
> +             irq_domain_deactivate_irq(&desc->irq_data);
> +
> +     if (affinity->is_managed) {
> +             irqd_set(&desc->irq_data, IRQD_AFFINITY_MANAGED);
> +             irqd_set(&desc->irq_data, IRQD_MANAGED_SHUTDOWN);
> +     }
> +
> +     cpumask_copy(desc->irq_common_data.affinity, &affinity->mask);
> +
> +     /* Restore the activation state */
> +     if (activated)
> +             irq_domain_deactivate_irq(&desc->irq_data);

Shouldn't this be irq_domain_activate_irq() ?

Thanks,
Daniel