Add a debug message for control validation (validate_new)
failures. This is useful to debug issues with ioctls such
as VIDIOC_TRY_EXT_CTRLS and VIDIOC_S_EXT_CTRLS.

Signed-off-by: Ezequiel Garcia <ezequ...@collabora.com>
---
 drivers/media/v4l2-core/v4l2-ctrls.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c 
b/drivers/media/v4l2-core/v4l2-ctrls.c
index 7febfbb256a6..3979e7924007 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls.c
@@ -4112,8 +4112,13 @@ static int try_set_ext_ctrls_common(struct v4l2_fh *fh,
                        struct v4l2_ctrl *ctrl = helpers[idx].ref->ctrl;
 
                        ret = user_to_new(cs->controls + idx, ctrl);
-                       if (!ret && ctrl->is_ptr)
+                       if (!ret && ctrl->is_ptr) {
                                ret = validate_new(ctrl, ctrl->p_new);
+                               if (ret)
+                                       dprintk(vdev,
+                                               "failed to validate control %s 
(%d)\n",
+                                               v4l2_ctrl_get_name(ctrl->id), 
ret);
+                       }
                        idx = helpers[idx].next;
                } while (!ret && idx);
 
-- 
2.27.0

Reply via email to