On Fri, 27 Nov 2020 at 09:06, Lee Jones <lee.jo...@linaro.org> wrote: > > On Fri, 20 Nov 2020, Krzysztof Kozlowski wrote: > > > The driver can match only via the DT table so the table should be always > > used and the of_match_ptr does not have any sense (this also allows ACPI > > matching via PRP0001, even though it is not relevant here). This fixes > > compile warning (!CONFIG_OF on x86_64): > > > > drivers/mfd/bcm590xx.c:95:34: warning: ‘bcm590xx_of_match’ defined but > > not used [-Wunused-const-variable=] > > > > Signed-off-by: Krzysztof Kozlowski <k...@kernel.org> > > --- > > drivers/mfd/bcm590xx.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Couple of small points: > > - Patch-sets, particularly large ones should have a cover letter. > - Subject lines follow English grammar conventions and should start > with an uppercase character.
Thanks for fixing this. I am not a native English speaker and I make mistakes. Either it is a grammar or convention mistake, I would appreciate it if you point them out, so I could learn from them. About the "start with an uppercase character", I actually on purpose changed my approach some time ago after seeing more senior kernel developers using this method (see commits from Linus Torvalds, Andrew Morton). After the subsystem prefix "mfd: ...." they start with lowercase. If you still insist that commit titles in MFD subsystem should use capital letter after the prefix, I will try to remember and follow this approach when sending patches to you. Best regards, Krzysztof
