On (20/11/29 18:00), Randy Dunlap wrote:
> On 11/29/20 5:44 PM, Sergey Senozhatsky wrote:
> > Some functions that are declared when CONFIG_POSIX_ACL is defined
> > are not declared when CONFIG_POSIX_ACL is not defined. Add the
> > missing ones:
> > set_posix_acl(), posix_acl_update_mode(), get_cached_acl(),
> > get_cached_acl_rcu(), set_cached_acl(), forget_cached_acl().
> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhat...@gmail.com>
>
> Hi,
>
> I can't find CONFIG_POSIX_ACL in the kernel source tree.
> Should it be CONFIG_FS_POSIX_ACL ?
Oh, yes, CONFIG_POSIX_ACL. My bad.
> How did you test this?
You know what - scratch this patch. Sorry for the noise.
Some of the posix_acl.h functions are guarded by ifdef/ifndef
CONFIG_FS_POSIX_ACL, and some are not. This can break the build
if the code in question doesn't use ifdef CONFIG_FS_POSIX_ACL
(which happens with our code). But this patch is not enough,
apparently, we need to add ifdef CONFIG_FS_POSIX_ACL to our
code anyway, because of, for instance, posix_acl_alloc() which
is undefined for !FS_POSIX_ACL builds. Sorry for the noise.
-ss
