pm_runtime_get_sync will increment pm usage counter even
failed. Forgetting to putting operation will result in a
reference leak here.

Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.

Fixes: cca1705c3d89 ("drm/rockchip: lvds: Add PX30 support")
Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Qinglang Miao <miaoqingl...@huawei.com>
---
 drivers/gpu/drm/rockchip/rockchip_lvds.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c 
b/drivers/gpu/drm/rockchip/rockchip_lvds.c
index f292c6a6e..c3b1ac484 100644
--- a/drivers/gpu/drm/rockchip/rockchip_lvds.c
+++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c
@@ -145,7 +145,7 @@ static int rk3288_lvds_poweron(struct rockchip_lvds *lvds)
                DRM_DEV_ERROR(lvds->dev, "failed to enable lvds pclk %d\n", 
ret);
                return ret;
        }
-       ret = pm_runtime_get_sync(lvds->dev);
+       ret = pm_runtime_resume_and_get(lvds->dev);
        if (ret < 0) {
                DRM_DEV_ERROR(lvds->dev, "failed to get pm runtime: %d\n", ret);
                clk_disable(lvds->pclk);
@@ -329,7 +329,7 @@ static int px30_lvds_poweron(struct rockchip_lvds *lvds)
 {
        int ret;
 
-       ret = pm_runtime_get_sync(lvds->dev);
+       ret = pm_runtime_resume_and_get(lvds->dev);
        if (ret < 0) {
                DRM_DEV_ERROR(lvds->dev, "failed to get pm runtime: %d\n", ret);
                return ret;
-- 
2.23.0

Reply via email to