From: Biwen Li <[email protected]>

commit 35425bafc772ee189e3c3790d7c672b80ba65909 upstream.

Fix a bug when not specify interrupts property in dts
as follows,
    rtc-pcf2127-i2c 1-0051: failed to request alarm irq
    rtc-pcf2127-i2c: probe of 1-0051 failed with error -22

Signed-off-by: Biwen Li <[email protected]>
Signed-off-by: Alexandre Belloni <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Cc: Rasmus Villemoes <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 drivers/rtc/rtc-pcf2127.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/rtc/rtc-pcf2127.c
+++ b/drivers/rtc/rtc-pcf2127.c
@@ -559,7 +559,7 @@ static int pcf2127_probe(struct device *
        pcf2127->rtc->set_start_time = true; /* Sets actual start to 1970 */
        pcf2127->rtc->uie_unsupported = 1;
 
-       if (alarm_irq >= 0) {
+       if (alarm_irq > 0) {
                ret = devm_request_threaded_irq(dev, alarm_irq, NULL,
                                                pcf2127_rtc_irq,
                                                IRQF_TRIGGER_LOW | IRQF_ONESHOT,
@@ -570,7 +570,7 @@ static int pcf2127_probe(struct device *
                }
        }
 
-       if (alarm_irq >= 0 || device_property_read_bool(dev, "wakeup-source")) {
+       if (alarm_irq > 0 || device_property_read_bool(dev, "wakeup-source")) {
                device_init_wakeup(dev, true);
                pcf2127->rtc->ops = &pcf2127_rtc_alrm_ops;
        }


Reply via email to