Dominique Martinet wrote on Tue, Dec 01, 2020: > > Since generic_file_splice_read() seems to just implement splice_read in > > terms of the read_iter operation, I simply added the generic implementation > > to the file operations, which fixed the error I was seeing. A quick grep > > indicates that this is what most other file systems do as well. > > Good catch, might as well do that. > I'm surprised you didn't hit the same problem with splice_write? > > I see iter_file_splice_write being used for it on many filesystems, > it's probably better to add both?
Yeah, I confirm both are needed (the second for the pipe -> fs side) This made me test copy_file_range, and it works with both as well (used not to) interestingly on older kernels this came as default somehow? I have splice working on 5.4.67 :/ so this broke somewhat recently... I'll add an extra patch with the second and take your patch. Thanks! -- Dominique
