On Tue, 2020-12-01 at 16:50 +0100, Michal Simek wrote: > Fix parameters alignment reported by checkpatch --strict.
Please use a newer checkpatch as the 80 column warning isn't enforced quite the same way. > diff --git a/include/linux/firmware/xlnx-zynqmp.h > b/include/linux/firmware/xlnx-zynqmp.h [] > @@ -456,7 +456,8 @@ static inline int zynqmp_pm_sd_dll_reset(u32 node_id, u32 > type) > } > > > static inline int zynqmp_pm_reset_assert(const enum zynqmp_pm_reset reset, > - const enum zynqmp_pm_reset_action assert_flag) > + const enum zynqmp_pm_reset_action > + assert_flag) I think these changes aren't very good as it separates the type from the variable name. > @@ -490,9 +491,10 @@ static inline int zynqmp_pm_release_node(const u32 node) > } > > > static inline int zynqmp_pm_set_requirement(const u32 node, > - const u32 capabilities, > - const u32 qos, > - const enum zynqmp_pm_request_ack ack) > + const u32 capabilities, > + const u32 qos, > + const enum zynqmp_pm_request_ack > + ack)
