On 12/1/20 11:19 AM, David Woodhouse wrote: > On Tue, 2020-12-01 at 09:48 +0000, David Woodhouse wrote: >> So I switched it to generate the hypercall page directly from the >> kernel, just like we do for the Hyper-V hypercall page. > > Speaking of Hyper-V... I'll post this one now so you can start heckling > it. > Xen viridian mode is indeed one thing that needed fixing. And definitely a separate patch as you do here. Both this one and the previous is looking good.
I suppose that because you switch to kvm_vcpu_write_guest() you no longer need to validate that the hypercall page is correct neither marking as dirty. Probably worth making that explicit in the commit message. > I won't post the rest as I go; not much of the rest of the series when > I eventually post it will be very new and exciting. It'll just be > rebasing and tweaking your originals and perhaps adding some tests. > Awesome!!
