Hi, On Wed, Dec 2, 2020 at 5:16 PM Stephen Boyd <[email protected]> wrote: > > There isn't any need to overwrite the mode here in the driver with what > has been detected by the firmware, such as DT or ACPI. In fact, if we > use the SPI CS gpio descriptor feature we will overwrite the mode with > SPI_MODE_0 where it already contains SPI_MODE_0 and more importantly > SPI_CS_HIGH. Clearing the SPI_CS_HIGH bit causes the CS line to toggle > when the device is probed when it shouldn't change, confusing the driver > and making it fail to probe. Drop the assignment and let the spi core > take care of it. > > Fixes: a17d94f0b6e1 ("mfd: Add ChromeOS EC SPI driver") > Cc: Simon Glass <[email protected]> > Cc: Gwendal Grignou <[email protected]> > Cc: Douglas Anderson <[email protected]> > Cc: Alexandru M Stan <[email protected]> > Signed-off-by: Stephen Boyd <[email protected]> > --- > drivers/platform/chrome/cros_ec_spi.c | 1 -
Reviewed-by: Douglas Anderson <[email protected]> Tested-by: Douglas Anderson <[email protected]>
