On Thu, Dec 3, 2020 at 3:09 AM Daniel Latypov <[email protected]> wrote: > > Use self.assertEqual/assertNotEqual() instead. > Besides being more appropriate in a unit test, it'll also give a better > error message by show the unexpected values. > > Also > * Delete redundant check of exception types. self.assertRaises does this. > * s/kall/call. There's no reason to name it this way. > * This is probably a misunderstanding from the docs which uses it > since `mock.call` is in scope as `call`. > > Signed-off-by: Daniel Latypov <[email protected]> > ---
Looks good, thanks! Reviewed-by: David Gow <[email protected]> -- David
