* H. Peter Anvin <[EMAIL PROTECTED]> wrote:
> Ingo Molnar wrote:
>>
>>> could we _please_ use basic tools as vmlinux size comparison and
>>> objcompare when unifying, to make sure it's a 100% identity conversion?
>>
>> case in point, the patch claims:
>>
>>>> No functional change is made.
>>
>> but vmlinux before/after size comparison shows:
>>
>> text data bss dec hex filename
>> 8802894 1224910 3526656 13554460 ced31c vmlinux.before
>> 8803042 1224910 3526656 13554608 ced3b0 vmlinux.after
>
> Well, "no functional changes" is not quite the same thing as "no
> object code changes".
yeah, true, but the safest way to ensure no functional changes is to get
identical object code. In sched-devel.git i include obj comparisons to
cleanup patches as a self-assurance (and later bughunt helper) to make
sure a cleanup is really just a cleanup.
also, this patch, at first sight, should result in very similar (perhaps
even the very same) object code. Not 1.2K larger.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
