Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: de10c1619c48 ("[media] smiapp: Get clock rate if it's not available
through DT")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zhang Changzhong <[email protected]>
---
drivers/media/i2c/smiapp/smiapp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp/smiapp-core.c
index 6fc0680..45394b9 100644
--- a/drivers/media/i2c/smiapp/smiapp-core.c
+++ b/drivers/media/i2c/smiapp/smiapp-core.c
@@ -2892,7 +2892,7 @@ static int smiapp_probe(struct i2c_client *client)
dev_err(&client->dev,
"can't set clock freq, asked for %u but
got %lu\n",
sensor->hwcfg->ext_clk, rate);
- return rval;
+ return -EINVAL;
}
} else {
sensor->hwcfg->ext_clk = clk_get_rate(sensor->ext_clk);
--
2.9.5
