On 12/4/20 6:16 PM, Arnd Bergmann wrote: > From: Arnd Bergmann <[email protected]> > > The use of SIMPLE_DEV_PM_OPS() means that the suspend/resume > functions are now unused when CONFIG_PM is disabled: > > drivers/clk/samsung/clk-exynos-clkout.c:219:12: error: 'exynos_clkout_resume' > defined but not used [-Werror=unused-function] > 219 | static int exynos_clkout_resume(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~ > drivers/clk/samsung/clk-exynos-clkout.c:210:12: error: > 'exynos_clkout_suspend' defined but not used [-Werror=unused-function] > 210 | static int exynos_clkout_suspend(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~~ > > Mark them as __maybe_unused to shut up the otherwise harmless warning. > > Fixes: 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to module driver") > Reviewed-by: Krzysztof Kozlowski <[email protected]> > Signed-off-by: Arnd Bergmann <[email protected]> > --- > v2: add proper changelog text > --- > drivers/clk/samsung/clk-exynos-clkout.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos-clkout.c > b/drivers/clk/samsung/clk-exynos-clkout.c > index 9ec2f40cc400..e6d6cbf8c4e6 100644 > --- a/drivers/clk/samsung/clk-exynos-clkout.c > +++ b/drivers/clk/samsung/clk-exynos-clkout.c > @@ -207,7 +207,7 @@ static int exynos_clkout_remove(struct platform_device > *pdev) > return 0; > } > > -static int exynos_clkout_suspend(struct device *dev) > +static int __maybe_unused exynos_clkout_suspend(struct device *dev) > { > struct exynos_clkout *clkout = dev_get_drvdata(dev); > > @@ -216,7 +216,7 @@ static int exynos_clkout_suspend(struct device *dev) > return 0; > } > > -static int exynos_clkout_resume(struct device *dev) > +static int __maybe_unused exynos_clkout_resume(struct device *dev) > { > struct exynos_clkout *clkout = dev_get_drvdata(dev); > >
Acked-by: Chanwoo Choi <[email protected]> Best Regards, Chanwoo Choi Samsung Electronics
