Hi Lyude,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20201204]
[cannot apply to linus/master drm/drm-next v5.10-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Lyude-Paul/drm-i915-Add-support-for-Intel-s-eDP-backlight-controls/20201205-063902
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/0day-ci/linux/commit/18a741e6e1a9f39966c71ef577ef96600891d7ac
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Lyude-Paul/drm-i915-Add-support-for-Intel-s-eDP-backlight-controls/20201205-063902
        git checkout 18a741e6e1a9f39966c71ef577ef96600891d7ac
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/msm/dp/dp_ctrl.c: In function 'dp_ctrl_use_fixed_nvid':
>> drivers/gpu/drm/msm/dp/dp_ctrl.c:1421:16: error: implicit declaration of 
>> function 'drm_dp_get_edid_quirks'; did you mean 'drm_do_get_edid'? 
>> [-Werror=implicit-function-declaration]
    1421 |  edid_quirks = drm_dp_get_edid_quirks(ctrl->panel->edid);
         |                ^~~~~~~~~~~~~~~~~~~~~~
         |                drm_do_get_edid
>> drivers/gpu/drm/msm/dp/dp_ctrl.c:1427:11: error: too many arguments to 
>> function 'drm_dp_has_quirk'
    1427 |   return (drm_dp_has_quirk(&ctrl->panel->desc, edid_quirks,
         |           ^~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/msm/dp/dp_ctrl.c:14:
   include/drm/drm_dp_helper.h:1895:1: note: declared here
    1895 | drm_dp_has_quirk(const struct drm_dp_desc *desc, enum drm_dp_quirk 
quirk)
         | ^~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +1421 drivers/gpu/drm/msm/dp/dp_ctrl.c

c943b4948b5848 Chandan Uddaraju 2020-08-27  1415  
c943b4948b5848 Chandan Uddaraju 2020-08-27  1416  static bool 
dp_ctrl_use_fixed_nvid(struct dp_ctrl_private *ctrl)
c943b4948b5848 Chandan Uddaraju 2020-08-27  1417  {
c943b4948b5848 Chandan Uddaraju 2020-08-27  1418        u8 *dpcd = 
ctrl->panel->dpcd;
c943b4948b5848 Chandan Uddaraju 2020-08-27  1419        u32 edid_quirks = 0;
c943b4948b5848 Chandan Uddaraju 2020-08-27  1420  
c943b4948b5848 Chandan Uddaraju 2020-08-27 @1421        edid_quirks = 
drm_dp_get_edid_quirks(ctrl->panel->edid);
c943b4948b5848 Chandan Uddaraju 2020-08-27  1422        /*
c943b4948b5848 Chandan Uddaraju 2020-08-27  1423         * For better interop 
experience, used a fixed NVID=0x8000
c943b4948b5848 Chandan Uddaraju 2020-08-27  1424         * whenever connected 
to a VGA dongle downstream.
c943b4948b5848 Chandan Uddaraju 2020-08-27  1425         */
c943b4948b5848 Chandan Uddaraju 2020-08-27  1426        if 
(drm_dp_is_branch(dpcd))
c943b4948b5848 Chandan Uddaraju 2020-08-27 @1427                return 
(drm_dp_has_quirk(&ctrl->panel->desc, edid_quirks,
c943b4948b5848 Chandan Uddaraju 2020-08-27  1428                                
DP_DPCD_QUIRK_CONSTANT_N));
c943b4948b5848 Chandan Uddaraju 2020-08-27  1429  
c943b4948b5848 Chandan Uddaraju 2020-08-27  1430        return false;
c943b4948b5848 Chandan Uddaraju 2020-08-27  1431  }
c943b4948b5848 Chandan Uddaraju 2020-08-27  1432  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to