Hi Wan, On Sun, Dec 06, 2020 at 09:56:47AM +0000, Wan Mohamad, Wan Ahmad Zainie wrote: > Hi Serge. > > > -----Original Message----- > > From: Serge Semin <[email protected]> > > Sent: Saturday, December 5, 2020 11:24 PM > > To: Nyman, Mathias <[email protected]>; Felipe Balbi > > <[email protected]>; Krzysztof Kozlowski <[email protected]>; Greg Kroah- > > Hartman <[email protected]>; Rob Herring > > <[email protected]>; Chunfeng Yun <[email protected]>; > > Wan Mohamad, Wan Ahmad Zainie > > <[email protected]> > > Cc: Serge Semin <[email protected]>; Serge Semin > > <[email protected]>; Alexey Malahov > > <[email protected]>; Pavel Parkhomenko > > <[email protected]>; Andy Gross > > <[email protected]>; Bjorn Andersson <[email protected]>; > > Manu Gautam <[email protected]>; Roger Quadros > > <[email protected]>; Lad Prabhakar <prabhakar.mahadev- > > [email protected]>; Yoshihiro Shimoda > > <[email protected]>; narmstrong > > <[email protected]>; Kevin Hilman <[email protected]>; > > Martin Blumenstingl <[email protected]>; linux-arm- > > [email protected]; [email protected]; linux- > > [email protected]; [email protected]; linux- > > [email protected]; [email protected]; linux- > > [email protected] > > Subject: [PATCH v5 19/19] dt-bindings: usb: intel,keembay-dwc3: Validate > > DWC3 sub-node > > > > Intel Keem Bay DWC3 compatible DT nodes are supposed to have a DWC > > USB3 compatible sub-node to describe a fully functioning USB interface. > > Let's > > use the available DWC USB3 DT schema to validate the Qualcomm DWC3 sub- > > nodes. > > > > Note since the generic DWC USB3 DT node is supposed to be named as > > generic USB HCD ("^usb(@.*)?") one we have to accordingly fix the sub- > > nodes name regexp and fix the DT node example. > > > > Signed-off-by: Serge Semin <[email protected]> >
> LGTM. With minor change to fix the typo above, Qualcomm to Intel > Keem Bay, > Acked-by: Wan Ahmad Zainie <[email protected]> Ah, right. Thanks for noticing that. A probability of copy-paste mistakes increases proportionally to the number sleepless hours.) -Sergey > > > > > --- > > > > Changelog v5: > > - This is a new patch created for the new Intel Keem Bay bindings file, > > which has been added just recently. > > --- > > .../devicetree/bindings/usb/intel,keembay-dwc3.yaml | 9 +++------ > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/intel,keembay- > > dwc3.yaml b/Documentation/devicetree/bindings/usb/intel,keembay- > > dwc3.yaml > > index dd32c10ce6c7..43b91ab62004 100644 > > --- a/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml > > +++ b/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml > > @@ -34,11 +34,8 @@ properties: > > # Required child node: > > > > patternProperties: > > - "^dwc3@[0-9a-f]+$": > > - type: object > > - description: > > - A child node must exist to represent the core DWC3 IP block. > > - The content of the node is defined in dwc3.txt. > > + "^usb@[0-9a-f]+$": > > + $ref: snps,dwc3.yaml# > > > > required: > > - compatible > > @@ -68,7 +65,7 @@ examples: > > #address-cells = <1>; > > #size-cells = <1>; > > > > - dwc3@34000000 { > > + usb@34000000 { > > compatible = "snps,dwc3"; > > reg = <0x34000000 0x10000>; > > interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>; > > -- > > 2.29.2 > > Best regards, > Zainie
