On Mon, 7 Dec 2020 07:57:27 +0000 Avri Altman <avri.alt...@wdc.com> wrote:
> > > > TP_printk( > > - "%s: %s: HDR:%s, CDB:%s", > > + "%s: %s: HDR:%s, %s:%s", > > __get_str(str), __get_str(dev_name), > > __print_hex(__entry->hdr, sizeof(__entry->hdr)), > > + __get_str(tsf_type), > This breaks what current parsers expects. > Why str is not enough to distinguish between the command? Hopefully it shouldn't. Reading from user space should use the libtraceevent library, that reads the format files and extracts the raw data to find the fields. As long as the field exists, it should not break user space parsers. If it does, please let me know, and I'll gladly help change the user space code to use libtraceevent :-) -- Steve
