On 12/07, Chao Yu wrote:
> On 2020/12/7 15:28, Daeho Jeong wrote:
> > > It looks like it will be better to move this into merge condition?
> > >
> > > if (bio && (!page_is_mergeable(sbi, bio,
> > > *last_block_in_bio, blkaddr) ||
> > > !f2fs_crypt_mergeable_bio(bio, inode, page->index,
> > > NULL) ||
> > > f2fs_verify_mergeable_bio())) {
> > >
> >
> > I tried this for the first time, but it requires unnecessary checks
> > within the compression cluster.
>
> We only need to check f2fs_verify_mergeable_bio for i == 0 case? something
> like:
>
> static bool f2fs_verify_mergeable_bio(struct bio *bio, bool verify, bool
> first_page)
> {
> if (!first_page)
Agreed that we don't need to run this instruction for every pages.
> return false;
> if (!verify)
> return false;
>
> ctx = bio->bi_private;
> if (!(ctx->enabled_steps & (1 << STEP_VERITY)))
> return true;
> }
>
> Thoughts?
>
> > I wanted to just check one time in the beginning of the cluster.
> > What do you think?
>
> It's trivial, but I'm think about the readability... at least, one line
> comment
> is needed to describe why we submit previous bio. :)
I added like this. :P
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=f189a2471df2560e5834d999ab4ff68bc10853e4
>
> Thanks,
>
> > .
> >
