Re: [PATCH 3/3] drivers: usb: atm: use pr_err() and pr_warn() instead of raw printk()

[Duncan Sands]

On 12/8/20 10:32 AM, Enrico Weigelt, metux IT consult wrote:

Since we have the nice helpers pr_err() and pr_warn(), use them instead
of raw printk().

Signed-off-by: Enrico Weigelt, metux IT consult <i...@metux.net>

Acked-by: Duncan Sands <duncan.sa...@free.fr>

---
  drivers/usb/atm/usbatm.c  | 2 +-
  drivers/usb/atm/xusbatm.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c
index 56fe30d247da..1c90aa273a41 100644
--- a/drivers/usb/atm/usbatm.c
+++ b/drivers/usb/atm/usbatm.c
@@ -1278,7 +1278,7 @@ EXPORT_SYMBOL_GPL(usbatm_usb_disconnect);
  static int __init usbatm_usb_init(void)
  {
        if (sizeof(struct usbatm_control) > sizeof_field(struct sk_buff, cb)) {
-               printk(KERN_ERR "%s unusable with this kernel!\n", 
usbatm_driver_name);
+               pr_err("%s unusable with this kernel!\n", usbatm_driver_name);
                return -EIO;
        }

diff --git a/drivers/usb/atm/xusbatm.c b/drivers/usb/atm/xusbatm.c

index ffc9810070a3..0befbf63d1cc 100644
--- a/drivers/usb/atm/xusbatm.c
+++ b/drivers/usb/atm/xusbatm.c
@@ -179,7 +179,7 @@ static int __init xusbatm_init(void)
            num_vendor != num_product ||
            num_vendor != num_rx_endpoint ||
            num_vendor != num_tx_endpoint) {
-               printk(KERN_WARNING "xusbatm: malformed module parameters\n");
+               pr_warn("xusbatm: malformed module parameters\n");
                return -EINVAL;
        }