On Fri, 4 Dec 2020 at 12:35, Stephen Boyd <swb...@chromium.org> wrote:
>
> There isn't any need to overwrite the mode here in the driver with what
> has been detected by the firmware, such as DT or ACPI. In fact, if we
> use the SPI CS gpio descriptor feature we will overwrite the mode with
> SPI_MODE_0 where it already contains SPI_MODE_0 and more importantly
> SPI_CS_HIGH. Clearing the SPI_CS_HIGH bit causes the CS line to toggle
> when the device is probed when it shouldn't change, confusing the driver
> and making it fail to probe. Drop the assignment and let the spi core
> take care of it.
>
> Fixes: a17d94f0b6e1 ("mfd: Add ChromeOS EC SPI driver")
> Cc: Simon Glass <s...@chromium.org>
> Cc: Gwendal Grignou <gwen...@chromium.org>
> Reviewed-by: Douglas Anderson <diand...@chromium.org>
> Tested-by: Douglas Anderson <diand...@chromium.org>
> Acked-by: Enric Balletbo i Serra <enric.balle...@collabora.com>
> Cc: Alexandru M Stan <ams...@chromium.org>
> Signed-off-by: Stephen Boyd <swb...@chromium.org>
> ---
> drivers/platform/chrome/cros_ec_spi.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Simon Glass <s...@chromium.org>
>
>
> diff --git a/drivers/platform/chrome/cros_ec_spi.c
> b/drivers/platform/chrome/cros_ec_spi.c
> index dfa1f816a45f..f9df218fc2bb 100644
> --- a/drivers/platform/chrome/cros_ec_spi.c
> +++ b/drivers/platform/chrome/cros_ec_spi.c
> @@ -742,7 +742,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)
> int err;
>
> spi->bits_per_word = 8;
> - spi->mode = SPI_MODE_0;
> spi->rt = true;
> err = spi_setup(spi);
> if (err < 0)
> --
> https://chromeos.dev
>
